Skip to content

[deps](jindofs) build.sh support any version of jindofs #49903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hello-stephen merged 2 commits into from
Apr 9, 2025
Merged

[deps](jindofs) build.sh support any version of jindofs #49903

hello-stephen merged 2 commits into from
Apr 9, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Apr 9, 2025 •
edited
Loading

What problem does this PR solve?

Followup #49886
Use regexp to match the different version of jindofs jars.
So that we don't need to modify build.sh again once the version of jindofs is changed

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Apr 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Apr 9, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

PR approved by anyone and no changes requested.

@morningman morningman mentioned this pull request Apr 9, 2025
Merged
@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 9, 2025

skip buildall

@hello-stephen hello-stephen merged commit ff7655b into apache:master Apr 9, 2025
30 of 31 checks passed
yiguolei pushed a commit that referenced this pull request Apr 10, 2025
@morningman
[deps](jindofs) add jindofs for 2.1 (#49259)(#49371)(#49374)(#49502)(#…
826cbfd 
…49503)(#49886)(#49903) (#49908)

bp (#49259)(#49371)(#49374)(#49502)(#49503)(#49886)(#49903)
morningman added a commit to morningman/doris that referenced this pull request Apr 21, 2025
@morningman
[deps](jindofs) build.sh support any version of jindofs (apache#49903)
6047794 
Followup apache#49886
Use regexp to match the different version of jindofs jars.
So that we don't need to modify `build.sh` again once the version of
jindofs is changed
@morningman morningman mentioned this pull request Apr 21, 2025
Closed
morningman added a commit to morningman/doris that referenced this pull request Apr 22, 2025
@morningman
[deps](jindofs) add jindofs for 2.1 (apache#49259)(apache#49371)(apac…
79bb9b1 
…he#49374)(apache#49502)(apache#49503)(apache#49886)(apache#49903) (apache#49908)

bp (apache#49259)(apache#49371)(apache#49374)(apache#49502)(apache#49503)(apache#49886)(apache#49903)
morningman added a commit to morningman/doris that referenced this pull request Apr 22, 2025
@morningman
[deps](jindofs) build.sh support any version of jindofs (apache#49903)
b337e98 
### What problem does this PR solve?

Followup apache#49886 
Use regexp to match the different version of jindofs jars.
So that we don't need to modify `build.sh` again once the version of
jindofs is changed
@morningman morningman mentioned this pull request Apr 22, 2025
Merged
dataroaring pushed a commit that referenced this pull request Apr 23, 2025
@morningman @hello-stephen
[deps](jindofs) add jindofs for 2.1 (#49259)(#49371)(#49374)(#49502)(#…
8aff230 
…49503)(#49886)(#49903)(#49963) (#50283)

bp (#49259)(#49371)(#49374)(#49502)(#49503)(#49886)(#49903)(#49963)

---------

Co-authored-by: Dongyang Li <lidongyang@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@morningman @koarz
[deps](jindofs) build.sh support any version of jindofs (apache#49903)
9c48d71 
### What problem does this PR solve?

Followup apache#49886 
Use regexp to match the different version of jindofs jars.
So that we don't need to modify `build.sh` again once the version of
jindofs is changed
@morningman morningman mentioned this pull request Jun 12, 2025
Merged
16 tasks
morningman added a commit that referenced this pull request Jun 14, 2025
@morningman
[opt](deps) add jindofs in classpath after hadoop libs (#51689)
ef1e7cc 
### What problem does this PR solve?

Related PR: #49903

Problem Summary:
We should add jindofs jars in CLASSPATH, but after hadoop jars.
So that we can use the right hadoop deps instead of deps from jindofs.
morningman added a commit to morningman/doris that referenced this pull request Jun 14, 2025
@morningman
[opt](deps) add jindofs in classpath after hadoop libs (apache#51689)
62a76f6 
Related PR: apache#49903

Problem Summary:
We should add jindofs jars in CLASSPATH, but after hadoop jars.
So that we can use the right hadoop deps instead of deps from jindofs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@hello-stephen hello-stephen hello-stephen approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.6-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morningman @Thearas @hello-stephen @BiteTheDDDDt @yiguolei @dataroaring